Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload feature fixes #301

Open
wants to merge 16 commits into
base: beta
Choose a base branch
from
Open

Upload feature fixes #301

wants to merge 16 commits into from

Conversation

ShresthPratapSingh
Copy link
Contributor

@ShresthPratapSingh ShresthPratapSingh commented Jun 29, 2020 •
edited
Loading

This PR completes the upload feature #239 .

The user can now add images, videos and documents. (#233 )

### This PR will close PR #244

*After merging feature/upload can be tested and then finally merged in beta.

@cpg
Copy link
Member

cpg commented Jul 2, 2020

Nothing can be read in iOS 12. Also, pushing one (not sure which one) of the icons, there is a crash:

...
AppDelegate.swift: syncWithUserDefaults() - Notifications on? false
2020-07-03 00:54:12.947107+0200 AmahiAnywhere[8424:4245927] *** Terminating app due to uncaught exception 'NSGenericException', reason: 'Your application has presented a UIAlertController (<UIAlertController: 0x1061be600>) of style UIAlertControllerStyleActionSheet from RootContainerViewController (<RootContainerViewController: 0x105813ea0>). The modalPresentationStyle of a UIAlertController with this style is UIModalPresentationPopover. You must provide location information for this popover through the alert controller's popoverPresentationController. You must provide either a sourceView and sourceRect or a barButtonItem.  If this information is not known when you present the alert controller, you may provide it in the UIPopoverPresentationControllerDelegate method -prepareForPopoverPresentation.'

@ShresthPratapSingh
Copy link
Contributor Author

ShresthPratapSingh commented Jul 5, 2020 •
edited
Loading

@cpg I've resolved the conflicts and crashes. This PR is ready to merge.

@cpg cpg mentioned this pull request Jul 6, 2020
Closed
@cpg cpg changed the title (Closes PR# 244)Upload feature Upload feature fixes Jul 20, 2020
@cpg cpg changed the base branch from feature/upload to beta July 20, 2020 12:03
@cpg cpg changed the base branch from beta to feature/upload July 20, 2020 13:14
@ShresthPratapSingh ShresthPratapSingh changed the base branch from feature/upload to beta August 24, 2020 18:15
@ShresthPratapSingh
Copy link
Contributor Author

@cpg I've changed the base to beta and resolved the conflicts. Ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpg cpg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShresthPratapSingh @cpg @Marton-Zeisler @csoni111 @iswiftshek